-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YleAreena] Add new extractor #20274
Conversation
Looks like Yle is using aggressive geo-blocking which prevents tests in CI from passing. This is a major problem, as I cannot provide a really big proxy service for every downloader and also believe that the extractor's main userbase is in Finland, which would make the proxy pretty pointless. How can this pull request proceed? |
Read coding conventions. |
Following the style guide a bit better
@dstftw could you elaborate more on what is wrong in this code regarding coding conventions? |
Bump. |
Bump. Anything still required here? |
Maybe code should look something like
instead of
Also trailing parenthesis probably should be located after last argument and not on a new line. |
7b956a1
to
5e26784
Compare
Bump. Thanks! |
What's actually left to be done to merge this? I can provide a proxy service for CI to run if required. |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This pull request adds a new extractor for Yle Areena, Finnish Broadcasting Company internet service. There has been an unmerged extractor pull request for both Yle Areena and Yle Elävä Arkisto using the old Flash player technology, but that player has been completely phased out from Yle Areena and replaced with Kaltura streaming service. As the codebases of these services differ greatly now, this project's scope is limited to be in Yle Areena.
Ping @hlintala for making the old extractor. Maybe the Yle Elävä Arkisto extractor might be resurrected from your code.