-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hhu] Add new extractor #22660
[hhu] Add new extractor #22660
Conversation
Read coding conventions. |
I read the coding conventions before but I didn't notice the rule regarding closing braces/brackets/parentheses. (I'm used to the guidelines in PEP8, sorry about that.) |
It does not say anything about brackets and braces. Also mostly it's nothing to do with closing parentheses which are perfectly valid PEP8. |
Some labels are of the form 'low quality (320p)'. This commit changes the regex so, that the whole label is searched for the number, not just the beginning.
The generic extractor doesn't work here because I modified my PR to at least use |
As already said jwplayer extraction code should be extended to support sanitizing function calls out of options JSON. HHU extractor must be removed. Extraction should be processed by generic extractor. |
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
HHU Mediathek contains videos created by the Heinrich-Heine-Universität Düsseldorf (mostly recordings of lectures).
This extractor allows the download of single, publicly visible videos.