Fix CCMA extractor #24157
Closed
Fix CCMA extractor #24157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, provided UTC timestamp does not comply ISO8601, as its
format is YYYY-DD-MM instead of expected YYYY-MM-DD.
This can be checked with the also provided "text" field of
emission date object. Example:
"data_emissio": {
"text": "14/05/2002�21:39",
"utc": "2002-14-05T21:39:28+0200"
}
This commit fixes this behavior.
Added test is one of the cases of broken compatibility. Issue is in featuring multiple languages in the subtitles field.
CCMA extractor used to raise an exception when attempting the download of a URL featuring multiple languages in the subtitles. When a single language is available, the field is the expected dict. When multiple languages are available, a list of dicts is provided. This commit fixes this issue.
5 tasks
|
please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Fixing two bugs present in CCMA extractor.
For some reason, provided UTC timestamp does not comply ISO8601, as its format is YYYY-DD-MM instead of expected YYYY-MM-DD.
This is made evident in the also provided
"text"field of emission date object. Example:The extractor used to raise an exception when attempting the download of a URL featuring multiple subtitle languages.
Behavior of the
subtitolsfield is:When a single language is available, the field is the expected
dict.When multiple languages are available, a
listofdictis provided.A test is added with an URL featuring multiple subtitles, to ensure no exception is raised during extraction.