Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CCMA extractor #24157

Closed
wants to merge 4 commits into from
Closed

Fix CCMA extractor #24157

wants to merge 4 commits into from

Commits on Feb 27, 2020

  1. [CCMA] Fix wrong timestamp issue

    For some reason, provided UTC timestamp does not comply ISO8601, as its
    format is YYYY-DD-MM instead of expected YYYY-MM-DD.
    
    This can be checked with the also provided "text" field of
    emission date object. Example:
    "data_emissio": {
                "text": "14/05/2002�21:39",
                "utc": "2002-14-05T21:39:28+0200"
    }
    
    This commit fixes this behavior.
    guillemglez committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    8fbefa5 View commit details
    Browse the repository at this point in the history
  2. [CCMA] Add test with multiple subtitles

    Added test is one of the cases of broken compatibility.
    Issue is in featuring multiple languages in the subtitles field.
    guillemglez committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    69c4e35 View commit details
    Browse the repository at this point in the history
  3. [CCMA] Fix multiple subtitles incompatibility

    CCMA extractor used to raise an exception when attempting the download of
    a URL featuring multiple languages in the subtitles.
    
    When a single language is available, the field is the expected dict.
    When multiple languages are available, a list of dicts is provided.
    
    This commit fixes this issue.
    guillemglez committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    8c60c29 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. Configuration menu
    Copy the full SHA
    b4a7030 View commit details
    Browse the repository at this point in the history