-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mediaklikk] Add new extractor #25098
Conversation
I tested it, I successfully downloaded videos from m4sport.hu. I had to modify only one line:
|
Added m4sport support, what do I need to do with this pull request to get processed? |
5e26784
to
da2069f
Compare
I also tested it, and I successfully downloaded videos from hirado.hu as well. Like asalamon74 I had to modify only one line: _VALID_URL = r'https?://(?:www.)?(?:mediaklikk|m4sport|hirado).hu(/\w+)*/(?P[^/]+)/?' |
Also note that the video that is listed in the pull request description, and is included in mediaklikk.py as test, is no longer available. I suggest updating these to a video that is likely to be more permanently present on the site, e.g. : https://mediaklikk.hu/adal2020/video/2020/03/07/a-dal-donto/ |
Thank you for including the hirado.hu fix! I created a pull request with a few minor additional edits, please accept if you agree with them. Also please update in the description of your pull request the link from https://mediaklikk.hu/video/kiberma-2020-04-30-i-adas/ to https://mediaklikk.hu/adal2020/video/2020/03/07/a-dal-donto/ |
Thank you for including the hirado.hu fix! I recently found an article offering solutions to download video from mediaklikk too. |
Original PR: ytdl-org/youtube-dl#17453, ytdl-org/youtube-dl#25098 Fixes: ytdl-org/youtube-dl#21431 Authored-by: tmarki, mrx23dot, coletdjnz
Original PR: ytdl-org/youtube-dl#17453, ytdl-org/youtube-dl#25098 Fixes: ytdl-org/youtube-dl#21431 Authored-by: tmarki, mrx23dot, coletdjnz
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Added extractor for this site: https://mediaklikk.hu/video/kiberma-2020-04-30-i-adas/
fixes #21431