Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[telegram] Add new extractor #25142

Closed
wants to merge 1 commit into from
Closed

[telegram] Add new extractor #25142

wants to merge 1 commit into from

Conversation

ESWZY
Copy link

@ESWZY ESWZY commented May 5, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description

Add new extractor for Telegram public channels like https://t.me/s/telegram/86

@dstftw
Copy link
Collaborator

dstftw commented May 5, 2020

Covered by generic extractor.

@dstftw dstftw closed this May 5, 2020
@ESWZY
Copy link
Author

ESWZY commented May 5, 2020

Covered by generic extractor.

Hi Sergey,

Thanks for your review.

The difference between this extractor and generic extractor is that this extrator can download video in specific message.

But, the generic extractor will download all of videos in this page, not the video in this message.

For example, if I want to download video in 86th message, the generic extractor will download two video 76, two video 80, two video 82, video 86, video 90. That may be difficult to manage.

So, I want to keep the extractor. Hope you can consider that.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants