[Mildom] Add new extractor #25958
Closed
[Mildom] Add new extractor #25958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianheine
reviewed
Aug 9, 2020
youtube_dl/extractor/mildom.py
Outdated
| 'info_dict': { | ||
| 'id': '10819667-1594032863', | ||
| 'ext': 'mp4', | ||
| 'title': '月曜!雀荘ほめちぎり #1', |
There was a problem hiding this comment.
Suggested change
| 'title': '月曜!雀荘ほめちぎり #1', | |
| 'title': '月曜!雀荘ほめちぎり #1 【麻雀】', |
(according to json)
adrianheine
reviewed
Aug 9, 2020
youtube_dl/extractor/mildom.py
Outdated
| def _real_extract(self, url): | ||
| channel_id, video_id = re.match(self._VALID_URL, url).groups() | ||
|
|
||
| webpage = self._download_webpage(url, video_id) |
There was a problem hiding this comment.
Maybe this could be done only if necessary to save one request?
adrianheine
reviewed
Aug 9, 2020
youtube_dl/extractor/mildom.py
Outdated
| if not thumbnail: | ||
| thumbnail = self._html_search_meta( | ||
| 'og:image', | ||
| webpage, 'thumbnail', default=None) |
There was a problem hiding this comment.
This could use _og_search_thumbnail instead:
thumbnail = self._og_search_thumbnail(webpage, default=None)
adrianheine
reviewed
Aug 9, 2020
youtube_dl/extractor/mildom.py
Outdated
|
|
||
| webpage = self._download_webpage(url, video_id) | ||
| video_data = self._download_json( | ||
| self._VIDEO_INFO_BASE_URL + '?v_id=%s' % video_id, video_id) |
There was a problem hiding this comment.
I think it's better to directly include '?v_id=%s' in _VIDEO_INFO_BASE_URL.
dstftw
force-pushed
the
master
branch
2 times, most recently
from
5e26784
to
da2069f
Compare
|
I'm not sure if it's okay to ask here, but is there any estimate when this is going to pushed into the master branch? |
adrianheine
approved these changes
Jan 11, 2021
|
This is waiting to be reviewed and merged by one of the maintainers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This Pull Request adds a new extractor for Mildom (mildom.com). Mildom is a relatively new Japanese live-streaming and video hosting platform with a focus on games. This PR adds an extractor for downloading videos from the site.