[StoryFire] Add new extractor #26349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realized I missed a playlist URL format from the original issue; I didn't find it in my tinkering with the site. |
|
Correction update added, should be good to go. I've rerun the tests to confirm. |
dstftw
force-pushed
the
master
branch
2 times, most recently
from
5e26784
to
da2069f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Add extractor for Storyfire video URLs, short URLs and user video list URLs - This addresses issue #25628
Extracted many optional parameters in a future-proof way that should not fail if the site makes minor changes over time.
Included test cases for all covered URLs and verified passing on python 3.7, 2.7, tried 2.6 but it does not seem to support newer TLS and failed the HTTPS requests.