Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playvids] Add new extractor #26798

Closed
wants to merge 1 commit into from
Closed

Conversation

AXDOOMER
Copy link

@AXDOOMER AXDOOMER commented Oct 3, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This PR adds a new extractor for playvids.com

Many URLs which could trigger edge cases were tested and no bug was found.

@dstftw
Copy link
Collaborator

dstftw commented Oct 17, 2020

Read coding conventions.

@AXDOOMER
Copy link
Author

@dstftw I did read them before coding. I also ran flake8 after coding to make sure everything was fine. Can you pinpoint what's wrong?

@cypheron
Copy link

I guess because of the huge backlog @dstftw doesn't actually check any code, he writes that "read the conventions" nonsense over all PR's without ever mentioning a specific thing. Hope that @dstftw can get off his horse and does some work, otherwise I don't know if my excitement about ytdl being back was really appropriate.

@dirkf dirkf mentioned this pull request Nov 9, 2022
11 tasks
@dirkf dirkf closed this in #29765 Nov 9, 2022
Vangelis66 referenced this pull request Nov 9, 2022
* Merge back-port from yt-dlp
* Merge features from PR #29798
* Improve metadata extraction

Co-authored-by: dirkf <fieldhouse@gmx.net>
Co-authored by: AXDOOMER
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants