Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zoom] Add new extractor #27002

Closed
wants to merge 9 commits into from
Closed

Conversation

Romern
Copy link

@Romern Romern commented Nov 16, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
    (the main part of the code is by me)
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)
    (see [zoom] new extractor blackjack4494/yt-dlc#108 for the change from zoomus to zoom)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Adds the zoom extractor. Original merge request is here: #24751
But I cannot access my repo as it is still DMCA'd, so I add the changes here

@Romern Romern mentioned this pull request Nov 16, 2020
9 tasks
@hiqua
Copy link

hiqua commented Nov 24, 2020

Thanks a lot for this extractor, FWIW it's been working well for me for some time (didn't have the chance to try the password feature though).

Are there still things to be done / tested before considering merging this?

@Romern
Copy link
Author

Romern commented Nov 24, 2020

From my side no, It was already merged into yt-dlc and worked for me since april.
The maintainers have to review the code, but considering the backlog of pull requests it could take a bit.

github-actions bot added a commit to hellopony/youtube-dl that referenced this pull request Mar 24, 2021
* https://github.com/ytdl-org/youtube-dl:
  [ard] improve clip id extraction(ytdl-org#22724)(closes ytdl-org#28528)
  release 2021.03.25
  [ChangeLog] Actualize [ci skip]
  [zoom] Add new extractor(closes ytdl-org#16597, closes ytdl-org#27002, closes ytdl-org#28531)
  [extractor] escape forgotten dot for hostnames in regular expression (ytdl-org#28530)
  [bbc] fix BBC IPlayer Episodes/Group extraction(closes ytdl-org#28360)
  [youtube] Fix default value for youtube_include_dash_manifest (closes ytdl-org#28523)
leshasmlesha pushed a commit to leshasmlesha/youtube-dl that referenced this pull request Apr 3, 2021
@upintheairsheep
Copy link

Yt-Dlp has zoom extraction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants