-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hse24] Add new extractor #27060
Open
cypheron
wants to merge
1
commit into
ytdl-org:master
Choose a base branch
from
cypheron:hse24
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[hse24] Add new extractor #27060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read coding conventions. |
As expected the build, now that it has run, has passed without any changes. |
@remitamine could you please review this code? otherwise I'm closing this PR, because i don't see "new extractor" PR's assigned to @dstftw getting anywhere. |
9 tasks
pukkandan
pushed a commit
to yt-dlp/yt-dlp
that referenced
this pull request
Dec 20, 2021
Original PR: ytdl-org/youtube-dl#27060 Authored by: cypheron, pukkandan
Lesmiscore
added a commit
to ytdl-patched/ytdl-patched
that referenced
this pull request
Dec 20, 2021
* 'master' of https://github.com/yt-dlp/yt-dlp: [dash,youtube] Download live from start to end (#888) [ondemandkorea] Update `jw_config` regex (#2056) [youtube:tab] Extract more metadata from feeds/channels/playlists (#1018) [hse] Add extractors (#1906) Original PR: ytdl-org/youtube-dl#27060 Authored by: cypheron, pukkandan [postprocessor/ffmpeg] Always add `faststart` Closes #1491 [Facebook] Handle redirect URLs Closes #1035 [ABC:iview] Add show extractor (#1630) [audiomack] Update album and song VALID_URL (#1203) [soundcloud] Add related tracks extractor (#1000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Extractor to pull videos from home-shopping site "hse24.de". Both product videos (
/dpl/p/product
) and show recordings (dpl/c/tv-shows
) are supported. Extractor extracts and lists all available formats (typically low, mid, high resolution/bitrate). Tests passed on Python2.7, Python3.6, Python3.8.P.S.
Very happy that YT-DL is back!! Very happy to be able to contribute. Thanks to Microsoft + GitHub!