Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hse24] Add new extractor #27060

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[hse24] Add new extractor #27060

wants to merge 1 commit into from

Conversation

cypheron
Copy link

@cypheron cypheron commented Nov 17, 2020

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Extractor to pull videos from home-shopping site "hse24.de". Both product videos (/dpl/p/product) and show recordings (dpl/c/tv-shows) are supported. Extractor extracts and lists all available formats (typically low, mid, high resolution/bitrate). Tests passed on Python2.7, Python3.6, Python3.8.

P.S.

Very happy that YT-DL is back!! Very happy to be able to contribute. Thanks to Microsoft + GitHub!

@dstftw
Copy link
Collaborator

dstftw commented Nov 18, 2020

Read coding conventions.

@cypheron
Copy link
Author

cypheron commented Nov 19, 2020

@dstftw I have. Please describe your issue with the code. Travis CI doesn't show any error as the build job appears to have been canceled (like lots of other recent jobs).
Re-triggered build by force push.

@cypheron
Copy link
Author

As expected the build, now that it has run, has passed without any changes.

@cypheron
Copy link
Author

cypheron commented Feb 1, 2021

@remitamine could you please review this code? otherwise I'm closing this PR, because i don't see "new extractor" PR's assigned to @dstftw getting anywhere.

@cypheron cypheron mentioned this pull request Dec 7, 2021
9 tasks
pukkandan pushed a commit to yt-dlp/yt-dlp that referenced this pull request Dec 20, 2021
Original PR: ytdl-org/youtube-dl#27060
Authored by: cypheron, pukkandan
Lesmiscore added a commit to ytdl-patched/ytdl-patched that referenced this pull request Dec 20, 2021
* 'master' of https://github.com/yt-dlp/yt-dlp:
  [dash,youtube] Download live from start to end (#888)
  [ondemandkorea] Update `jw_config` regex (#2056)
  [youtube:tab] Extract more metadata from feeds/channels/playlists (#1018)
  [hse] Add extractors (#1906) Original PR: ytdl-org/youtube-dl#27060 Authored by: cypheron, pukkandan
  [postprocessor/ffmpeg] Always add `faststart` Closes #1491
  [Facebook] Handle redirect URLs Closes #1035
  [ABC:iview] Add show extractor (#1630)
  [audiomack] Update album and song VALID_URL (#1203)
  [soundcloud] Add related tracks extractor (#1000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants