Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Generic] RSS adding item description #27177

Merged
merged 6 commits into from
Dec 6, 2020
Merged

[Generic] RSS adding item description #27177

merged 6 commits into from
Dec 6, 2020

Conversation

renalid
Copy link
Contributor

@renalid renalid commented Nov 24, 2020

Add description of RSS feed's items

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Adding the RSS feed items description if it's available in order to get complete information from the feed.

Add description of RSS feed's items
Copy link
Collaborator

@dstftw dstftw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test.

@renalid
Copy link
Contributor Author

renalid commented Nov 29, 2020

@dstftw test added. Thanks :-)

Comment on lines 2216 to 2217
item_desc_el = it.find('description')
item_desc = None if item_desc_el is None else item_desc_el.text
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use xpath_text instead.

Comment on lines 218 to 234
{
'url': 'http://radiofrance-podcast.net/podcast09/rss_14631.xml',
'info_dict': {
'id': 'http://radiofrance-podcast.net/podcast09/rss_14631.xml',
'title': 'Certains l\'aiment Fip',
'description': 're:.*FIP met le cinéma.*'
},
'playlist': [{
'info_dict': {
'id': '14631-22.11.2020-ITEMA_22491517-2020Y24252S0327',
'ext': 'mp3',
'title': 'Les musiques de Valérie Lemercier',
'description': 're:.*occasion de la sortie.*',
'upload_date': '20201122',
},
}],
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renalid renalid requested a review from dstftw December 6, 2020 10:46
@dstftw dstftw merged commit cc017e0 into ytdl-org:master Dec 6, 2020
ThirumalaiK pushed a commit to ThirumalaiK/youtube-dl that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants