-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Generic] RSS adding item description #27177
Conversation
Add description of RSS feed's items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test.
@dstftw test added. Thanks :-) |
youtube_dl/extractor/generic.py
Outdated
item_desc_el = it.find('description') | ||
item_desc = None if item_desc_el is None else item_desc_el.text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use xpath_text
instead.
youtube_dl/extractor/generic.py
Outdated
{ | ||
'url': 'http://radiofrance-podcast.net/podcast09/rss_14631.xml', | ||
'info_dict': { | ||
'id': 'http://radiofrance-podcast.net/podcast09/rss_14631.xml', | ||
'title': 'Certains l\'aiment Fip', | ||
'description': 're:.*FIP met le cinéma.*' | ||
}, | ||
'playlist': [{ | ||
'info_dict': { | ||
'id': '14631-22.11.2020-ITEMA_22491517-2020Y24252S0327', | ||
'ext': 'mp3', | ||
'title': 'Les musiques de Valérie Lemercier', | ||
'description': 're:.*occasion de la sortie.*', | ||
'upload_date': '20201122', | ||
}, | ||
}], | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add description check to http://podcastfeeds.nbcnews.com/audio/podcast/MSNBC-MADDOW-NETCAST-M4V.xml test instead.
Add description of RSS feed's items
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Adding the RSS feed items description if it's available in order to get complete information from the feed.