Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Generic] RSS adding item description #27177

Merged
merged 6 commits into from
Dec 6, 2020
Merged

[Generic] RSS adding item description #27177

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
de31e7f
[Generic] RSS adding item description
renalid Nov 24, 2020
b3db1ec
Adding test for RSS item description
renalid Nov 29, 2020
11f6c07
[Generic] change test case expected + xpath method for item desc.
renalid Dec 4, 2020
b6e37da
[Generic] flake8 review syntax fix
renalid Dec 4, 2020
cdc3b5c
Update generic.py
dstftw Dec 6, 2020
bd989ca
Update generic.py
dstftw Dec 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions youtube_dl/extractor/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,19 @@ class GenericIE(InfoExtractor):
{
'url': 'http://podcastfeeds.nbcnews.com/audio/podcast/MSNBC-MADDOW-NETCAST-M4V.xml',
'info_dict': {
'id': 'pdv_maddow_netcast_m4v-02-27-2015-201624',
'ext': 'm4v',
'upload_date': '20150228',
'title': 'pdv_maddow_netcast_m4v-02-27-2015-201624',
}
'id': 'http://podcastfeeds.nbcnews.com/nbcnews/video/podcast/MSNBC-MADDOW-NETCAST-M4V.xml',
'title': 'MSNBC Rachel Maddow (video)',
'description': 're:.*her unique approach to storytelling.*',
},
'playlist': [{
'info_dict': {
'ext': 'mov',
'id': 'pdv_maddow_netcast_mov-12-03-2020-223726',
'title': 'MSNBC Rachel Maddow (video) - 12-03-2020-223726',
'description': 're:.*her unique approach to storytelling.*',
'upload_date': '20201204',
},
}],
},
# RSS feed with enclosures and unsupported link URLs
{
Expand Down Expand Up @@ -2199,6 +2207,7 @@ def _extract_rss(self, url, video_id, doc):
'_type': 'url_transparent',
'url': next_url,
'title': it.find('title').text,
'description': xpath_text(it, 'description', default=None),
})

return {
Expand Down