Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ninjastream] Add new extractor #27983

Closed
wants to merge 2 commits into from
Closed

[ninjastream] Add new extractor #27983

wants to merge 2 commits into from

Conversation

ProgrammingByPermutation

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Adding a new extractor for the https://ninjastream.to website.

@dstftw
Copy link
Collaborator

dstftw commented Jan 27, 2021

Read coding conventions.

@ProgrammingByPermutation
Copy link
Author

Read coding conventions.

@dstftw Can you please confirm if this addresses the coding convention issues?

@cypheron
Copy link

cypheron commented Feb 1, 2021

@ProgrammingByPermutation again check #27691 - imho no point in opening PR's in this project as long as they don't get responsible maintainers.

@bersbersbers
Copy link

bersbersbers commented May 2, 2021

I installed from 5adc36f, but I am getting

WARNING: unable to extract file-watch-jwplayer

This seems to be addressed in #28928, which is working fine. Mentioning this here for anyone stumbling across this PR in #28054 (which could be updated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants