[YSQL] ERROR: The column already exists when trying to add column after dropping with drop domain cascade

[archit-rastogi]

Jira Link: DB-11776

Description

Step to reproduce:

1. create domain
2. create table with one or more columns using the domain type created in step 1.
3. drop domain cascade
4. check table schema with \d, column(s) must be dropped.
5. create domain again
6. alter table add column with same name and domain type in step (5). ALTER table fails with column already exists.

Example:

yugabyte=# CREATE DOMAIN postal_code AS TEXT CHECK(VALUE ~ '^\d{5}$' OR VALUE ~ '^\d{5}-\d{4}$');
CREATE DOMAIN
yugabyte=# CREATE TABLE person(first_name TEXT, last_name TEXT, post postal_code, joining date);
CREATE TABLE
yugabyte=# insert into person values ('arc', 'ras', 12345, '12-12-2000');
yugabyte=# drop domain postal_code cascade;
NOTICE:  drop cascades to column post of table person
DROP DOMAIN
yugabyte=# \d person
               Table "public.person"
   Column   | Type | Collation | Nullable | Default 
------------+------+-----------+----------+---------
 first_name | text |           |          | 
 last_name  | text |           |          | 
 joining    | date |           |          | 

yugabyte=# CREATE DOMAIN postal_code AS TEXT CHECK(VALUE ~ '^\d{5}$' OR VALUE ~ '^\d{5}-\d{4}$');
CREATE DOMAIN
yugabyte=# alter table person add column post postal_code;
ERROR:  The column already exists: post
yugabyte=# alter table person add column post postal_code;
ERROR:  The column already exists: post
yugabyte=# \d
         List of relations
 Schema |  Name  | Type  |  Owner   
--------+--------+-------+----------
 public | person | table | yugabyte
(1 row)

yugabyte=# \d person
               Table "public.person"
   Column   | Type | Collation | Nullable | Default 
------------+------+-----------+----------+---------
 first_name | text |           |          | 
 last_name  | text |           |          | 
 joining    | date |           |          | 

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

• I confirm this issue does not contain any sensitive information.