Widget modality gets confused by cloned masks #1175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 10, 2013 11:45
If a modal widget and it's mask were cloned by other code (i.e. a drag/drop proxy) the document could have multiple masks. This confuses modality, as it uses the first mask and could reposition it after the second. Things go downhill from there… The chosen fix is to keep a reference to the mask rather than search for it each time. An alternative would be to search the entire document and delete extra masks, but I thought that too ugly.
|
|
||
| this.widget.hide(); | ||
| orig_mask = Y.one('.yui3-widget-mask'); | ||
| Assert.areSame(orig_mask, this.widget.get('maskNode'); |
There was a problem hiding this comment.
You seem to have forgotten a parentheses at the end of this line, which results in a parse error.
This line should be corrected to:
Assert.areSame(orig_mask, this.widget.get('maskNode'));
There was a problem hiding this comment.
On Thu, Sep 26, 2013 at 02:51:47PM -0700, Ezequiel Rodriguez wrote:
Assert.areSame(orig_mask, this.widget.get('maskNode');You seem to have forgotten a parentheses at the end of this line, which results in a parse error.
This line should be corrected to:
Assert.areSame(orig_mask, this.widget.get('maskNode'));
Many thanks!
I've just corrected that. I did try interpret the travis CI failure, but
gave up when it just said "SyntaxError: Parse error" without further
context.
Brian Sutherland
|
ccing @derek to take a look. |
|
Thanks. Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop widget-modality being confused by multiple masks
If a modal widget and it's mask were cloned by other
code (i.e. a drag/drop proxy) the document could have
multiple masks. This confuses modality, as it uses the
first mask and could reposition it after the second.
Things go downhill from there…
The chosen fix is to keep a reference to the mask
rather than search for it each time. An alternative
would be to search the entire document and delete
extra masks, but I thought that too ugly.