Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget modality gets confused by cloned masks #1175

Closed

Commits on Sep 10, 2013

  1. Stop widget-modality being confused by multiple masks

    If a modal widget and it's mask were cloned by other
    code (i.e. a drag/drop proxy) the document could have
    multiple masks. This confuses modality, as it uses the
    first mask and could reposition it after the second.
    Things go downhill from there…
    
    The chosen fix is to keep a reference to the mask
    rather than search for it each time. An alternative
    would be to search the entire document and delete
    extra masks, but I thought that too ugly.
    Brian Sutherland committed Sep 10, 2013
    Configuration menu
    Copy the full SHA
    50f1239 View commit details
    Browse the repository at this point in the history
  2. cleanups suggested by lint

    Brian Sutherland committed Sep 10, 2013
    Configuration menu
    Copy the full SHA
    5349d21 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2013

  1. try get out of the wet paper bag

    Brian Sutherland committed Sep 27, 2013
    Configuration menu
    Copy the full SHA
    c16ee9f View commit details
    Browse the repository at this point in the history