-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent default page action when starting a gesturemove #1557
Conversation
This prevents some browsers from selecting the page text during a gesture.
Unit test results from yeti:
I'm fairly sure that the warnings relate to browsers dropping off during testing. I live in Australia and some of the kind victims doing my testing are located half way across the world. Latency is a little high and yeti does not cope well with it. |
Are we good to pull this now @clarle? Cheers, Andrew |
Merged into Thanks again for the contribution, @andrewnicols! |
I'm seeing a side effect of this where the momentum scrolling on ios no longer works. Please see #1716. |
Android browsers require that we prevent the default browser action on the start of drag. We tried this in yui#693/yui#1557, but this broke in other ways for other browsers. The issue stems from preventDefault being called on the document instead of the Node. This commit moves the preventDefault to the gesturemovestart in the prototype for DD.Drag.
This prevents some browsers from selecting the page text during a gesture.