Move preventDefault to gesturemovestart (Fixes #1716) #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android browsers require that we prevent the default browser action on the start of drag. We tried this in yui#693/yui#1557, but this broke in other ways for other browsers. The issue stems from preventDefault being called on the document instead of the Node. This commit moves the preventDefault to the gesturemovestart in the prototype for DD.Drag.
|
CLA is valid! |
|
Tested (successfully) against:
I've tried against the following examples:
@tilomitra has worked on this with me and tested on some additional browsers too. |
|
It also works in Android 4.3. I'm 👍 with this change. Waiting to see what reviewers think. |
|
Merging this in since 72 hours have passed. |
tilomitra
added a commit
that referenced
this pull request
Mar 25, 2014
Move preventDefault to gesturemovestart (Fixes #1716)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android browsers require that we prevent the default browser action on the start of drag. We tried this in #693/#1557, but this broke in other ways for other browsers.
The issue stems from preventDefault being called on the document instead of the Node.
This commit moves the preventDefault to the
gesturemovestartin the prototype forDD.Dragso that the page is still scrollable.