[dd-ddm] : Fix #1492 regression "Drop Based Coding"

[hacklschorsch]

Fixes #1492 (#1492)

At ~ 3.7.3 a regression was introduced by 1a55a78 that broke
"Drop Based Coding" by using Array.each() for otherDrops which
is an Object Literal.

[okuryu]

Thanks for your patch. I prefer using Y.Object.each() instead of Y.each() for the performance at this case.

Also, I think it need to change ddm-drop.js#L250-254 to Y.Object.each() equivalently.

                Y.Array.each(drops, function(v) {
                    if (v !== biggest) {
                        out.push(v);
                    }
                }, this);

[hacklschorsch]

Yes, thanks!

I hope the thing will never ever be an array. To be quite frank I haven't understood why it is an object anyway. Whatev, please make it work.

I think it would be nice if Y.Array.each and Y.Object.each would at least throw an exception in debug builds of YUI when being fed objects of the wrong type.

[okuryu]

I hope the thing will never ever be an array. To be quite frank I haven't understood why it is an object anyway. Whatev, please make it work.

otherDrops property always works as an object as far as I can see.

I think it would be nice if Y.Array.each and Y.Object.each would at least throw an exception in debug builds of YUI when being fed objects of the wrong type.

Y.Array.each() actually calls ES5 native Array.forEach() if it available. if you passed an object to Y.Array.each(), they will be ignored. Also, Y.Object.each() works with both object and array. Example is here: http://jsbin.com/UNadUse/1/edit?html,js,console

[hacklschorsch]

Thanks @okuryu, I wasn't aware of that. I added commits to the PR which include your suggestions. HTH & greetings from Munich!

[okuryu]

@hacklschorsch Thanks! Are you signed our CLA already?

[hacklschorsch]

Just now e-Signed it. Thanks!

[okuryu]

Looks good to me. Current status is waiting any feedbacks by other Committers and Reviewers. I'll merge this after 72 hours or when get explicit approval by a Reviewer.

[hacklschorsch]

Mercí <3

[okuryu]

I've merged this into dev-master branch. I believe it'll be available in the next release.