Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dd-ddm] : Fix #1492 regression "Drop Based Coding" #1573

Merged
merged 4 commits into from
Jan 29, 2014
Merged

[dd-ddm] : Fix #1492 regression "Drop Based Coding" #1573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca13211
[dd-ddm] : Fix #1492 regression "Drop Based Coding"
hacklschorsch Jan 23, 2014
8677721
[dd-ddm] : Fix #1492 (build files)
hacklschorsch Jan 23, 2014
9b5f1c1
[dd-ddm] : Fix #1492 regression "Drop Based Coding"
hacklschorsch Jan 25, 2014
b7a6d1a
[dd-ddm] : Fix #1492 (build files)
hacklschorsch Jan 25, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/dd-ddm-drop/dd-ddm-drop-coverage.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions build/dd-ddm-drop/dd-ddm-drop-debug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ YUI.add('dd-ddm-drop', function (Y, NAME) {
getBestMatch: function(drops, all) {
var biggest = null, area = 0, out;

Y.Array.each(drops, function(v) {
Y.Object.each(drops, function(v) {
var inter = this.activeDrag.get('dragNode').intersect(v.get('node'));
v.region.area = inter.area;

Expand All @@ -249,7 +249,7 @@ YUI.add('dd-ddm-drop', function (Y, NAME) {
if (all) {
out = [];
//TODO Sort the others in numeric order by area covered..
Y.Array.each(drops, function(v) {
Y.Object.each(drops, function(v) {
if (v !== biggest) {
out.push(v);
}
Expand Down Expand Up @@ -304,7 +304,7 @@ YUI.add('dd-ddm-drop', function (Y, NAME) {
if (this._hasActiveShim()) {
this._handleTargetOver();
} else {
Y.Array.each(this.otherDrops, function(v) {
Y.Object.each(this.otherDrops, function(v) {
v._handleOut.apply(v, []);
});
}
Expand Down
2 changes: 1 addition & 1 deletion build/dd-ddm-drop/dd-ddm-drop-min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions build/dd-ddm-drop/dd-ddm-drop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ YUI.add('dd-ddm-drop', function (Y, NAME) {
getBestMatch: function(drops, all) {
var biggest = null, area = 0, out;

Y.Array.each(drops, function(v) {
Y.Object.each(drops, function(v) {
var inter = this.activeDrag.get('dragNode').intersect(v.get('node'));
v.region.area = inter.area;

Expand All @@ -249,7 +249,7 @@ YUI.add('dd-ddm-drop', function (Y, NAME) {
if (all) {
out = [];
//TODO Sort the others in numeric order by area covered..
Y.Array.each(drops, function(v) {
Y.Object.each(drops, function(v) {
if (v !== biggest) {
out.push(v);
}
Expand Down Expand Up @@ -304,7 +304,7 @@ YUI.add('dd-ddm-drop', function (Y, NAME) {
if (this._hasActiveShim()) {
this._handleTargetOver();
} else {
Y.Array.each(this.otherDrops, function(v) {
Y.Object.each(this.otherDrops, function(v) {
v._handleOut.apply(v, []);
});
}
Expand Down
6 changes: 3 additions & 3 deletions src/dd/js/ddm-drop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@
getBestMatch: function(drops, all) {
var biggest = null, area = 0, out;

Y.Array.each(drops, function(v) {
Y.Object.each(drops, function(v) {
var inter = this.activeDrag.get('dragNode').intersect(v.get('node'));
v.region.area = inter.area;

Expand All @@ -247,7 +247,7 @@
if (all) {
out = [];
//TODO Sort the others in numeric order by area covered..
Y.Array.each(drops, function(v) {
Y.Object.each(drops, function(v) {
if (v !== biggest) {
out.push(v);
}
Expand Down Expand Up @@ -302,7 +302,7 @@
if (this._hasActiveShim()) {
this._handleTargetOver();
} else {
Y.Array.each(this.otherDrops, function(v) {
Y.Object.each(this.otherDrops, function(v) {
v._handleOut.apply(v, []);
});
}
Expand Down