Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting custom elements #371

Merged
merged 1 commit into from
Aug 11, 2015
Merged

Conversation

andyearnshaw
Copy link
Contributor

This covers the requirements laid out in #328 by providing a new top-level @element tag, as well as adding subtags @parents, @content and @interface.

  • Supports @example, @deprecated, etc
  • Can specify permitted parents or content
  • The interface/class for the custom element is automatically cross-linked
  • Cross-linking is supported via {{#crossLink <x-foo attr>}}
  • Basic rendering done in both simple and default themes

Please review and let me know if there's anything I've missed or overlooked.

@okuryu
Copy link
Member

okuryu commented Jul 30, 2015

Thanks! I'd like to review within a week.

@@ -0,0 +1,80 @@
<h1>&lt{{name}}&gt;</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&lt;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, I'll fix this shortly!

@okuryu
Copy link
Member

okuryu commented Aug 2, 2015

It looks great to me, and I feel that it needs to update user guide for this.

@okuryu okuryu added this to the v0.9.0 milestone Aug 2, 2015
@okuryu
Copy link
Member

okuryu commented Aug 8, 2015

I just tweaked docs.
andyearnshaw#1

Update docs on supporting Custom Elements
@okuryu okuryu merged commit 52bbd25 into yui:master Aug 11, 2015
@okuryu
Copy link
Member

okuryu commented Aug 11, 2015

I've merged this. I'm planning to release the next version in this week. This feature will be available in the next version. Thanks your great contributions. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants