Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Refactor camera frame creation APIs #22

Merged
merged 5 commits into from
Oct 22, 2023

Conversation

yxlao
Copy link
Owner

@yxlao yxlao commented Oct 22, 2023

This is an API-breaking change.

Summary

# Create camera frame with Ks, Ts.
ct.camera.create_camera_frames(Ks=Ks, Ts=Ts)

# Create camera frames with Ts only.
ct.camera.create_camera_frames_with_Ts(Ts)  # Equivlaent to below
ct.camera.create_camera_frames(Ks=None, Ts=Ts)

# Create camera frames without up_triangle.
ct.camera.create_camera_frames(up_triangle=False)

# Create camera frames with center ray.
ct.camera.create_camera_frames(center_ray = True)

Changes

  • Rename ct.camera.create_camera_ray_frames() to ct.camera.create_camera_frames().
  • Remove ct.camera.create_camera_center_ray() and ct.camera.create_camera_center_rays()
    • This can be controlled by the center_ray parameter in ct.camera.create_camera_frames.

@yxlao yxlao changed the title Refactor camera frame creation APIs [Refactor] Refactor camera frame creation APIs Oct 22, 2023
@yxlao yxlao marked this pull request as ready for review October 22, 2023 21:15
@yxlao yxlao merged commit 3871b62 into master Oct 22, 2023
3 checks passed
@yxlao yxlao deleted the yixing/camera-frame-refactor branch October 22, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant