skipper: update canary version to v0.21.84 #7450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
major
|
👍 |
|
You must include |
[Changes](zalando/skipper@v0.21.76...v0.21.84) * zalando/skipper#3060 * zalando/skipper#3061 * zalando/skipper#3062 * zalando/skipper#3063 * zalando/skipper#3064 * zalando/skipper#3057 * zalando/skipper#3055 * zalando/skipper#3053 Also configures required min-drop-probability for passive health checker. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
skipper/update-version-v0.21.84
branch
from
e06411c to
6f770c3
Compare
| @@ -79,7 +79,7 @@ skipper_ingress_max_replicas: "50" | |||
| {{end}} | |||
| skipper_ingress_cpu: "1000m" | |||
| skipper_ingress_memory: "1500Mi" | |||
| skipper_ingress_health_check_options: "period=10s,min-requests=10,max-drop-probability=0.9" | |||
| skipper_ingress_health_check_options: "period=10s,min-requests=10,min-drop-probability=0.05,max-drop-probability=0.9" | |||
There was a problem hiding this comment.
@RomanZavodskikh noted this will fail for non-canary.
There was a problem hiding this comment.
e2e failed as expected:
message: back-off 5m0s restarting failed container=skipper-ingress pod=skipper-ingress-7bc5947c75-z7cfs_kube-system(3ceafbb0-546c-42e7-ac35-c5e0a219e8d5)
reason: CrashLoopBackOff
|
Will open a new PR as we decided to add default value for |
AlexanderYastrebov
added a commit
that referenced
this pull request
May 7, 2024
[Changes](zalando/skipper@v0.21.76...v0.21.86) * zalando/skipper#3067 * zalando/skipper#3066 * zalando/skipper#3060 * zalando/skipper#3061 * zalando/skipper#3062 * zalando/skipper#3063 * zalando/skipper#3064 * zalando/skipper#3057 * zalando/skipper#3055 * zalando/skipper#3053 See closed #7450 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Also configures required min-drop-probability for passive health checker.