Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filters/auth: extend jwtMetrics opt-out options #3055

Merged

Conversation

AlexanderYastrebov
Copy link
Member

Allow opt-out via state bag key.
The usecase is to opt-out metrics collection for routes that use oauthTokeninfo* and oauthGrant filters.

Allow opt-out via state bag key.
The usecase is to opt-out metrics collection for routes that use
`oauthTokeninfo*` and `oauthGrant` filters.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov AlexanderYastrebov added the minor no risk changes, for example new filters label Apr 30, 2024
@szuecs
Copy link
Member

szuecs commented Apr 30, 2024

👍

1 similar comment
@AlexanderYastrebov
Copy link
Member Author

👍

@AlexanderYastrebov AlexanderYastrebov merged commit d0d558e into master Apr 30, 2024
14 checks passed
@AlexanderYastrebov AlexanderYastrebov deleted the filters/auth/jwtMetrics-state-bag-opt-out branch April 30, 2024 17:44
AlexanderYastrebov added a commit that referenced this pull request May 6, 2024
Follow up on #3055

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request May 6, 2024
AlexanderYastrebov added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request May 6, 2024
[Changes](zalando/skipper@v0.21.76...v0.21.84)

* zalando/skipper#3060
* zalando/skipper#3061
* zalando/skipper#3062
* zalando/skipper#3063
* zalando/skipper#3064
* zalando/skipper#3057
* zalando/skipper#3055
* zalando/skipper#3053

Also configures required min-drop-probability for passive health checker.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit that referenced this pull request May 7, 2024
Follow up on #3055

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request May 7, 2024
JanardhanSharma pushed a commit to JanardhanSharma/skipper that referenced this pull request Jul 19, 2024
Allow opt-out via state bag key.
The usecase is to opt-out metrics collection for routes that use
`oauthTokeninfo*` and `oauthGrant` filters.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
JanardhanSharma pushed a commit to JanardhanSharma/skipper that referenced this pull request Jul 19, 2024
Follow up on zalando#3055

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor no risk changes, for example new filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants