skipper-canary: update logs destination #8200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provide pod name as env variable Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber
added
the
minor
|
👍 |
1 similar comment
|
👍 |
Merged
Comment on lines
+21
to
+24
| annotations: | ||
| kubernetes-log-watcher/scalyr-parser: | | ||
| [{"container": "controller", "parser": "keyValue"}] | ||
| logging/destination: "{{ .Cluster.ConfigItems.log_destination_both }}" |
There was a problem hiding this comment.
@MustafaSaber I think the indent needs to align with labels and not metadata. CLM fails to apply the changes: https://app.eu.scalyr.com/y/YiQ9PHLSFdM
strict decoding error: unknown field \"spec.jobTemplate.spec.template.annotations
Closed
MustafaSaber
added a commit
that referenced
this pull request
Sep 25, 2024
follow up on #8200 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide pod name as env variable