Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipper-canary: update logs destination #8200

Merged
merged 1 commit into from
Sep 25, 2024
Merged

skipper-canary: update logs destination #8200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cluster/manifests/skipper-canary-controller/canary-cronjob.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ spec:
labels:
application: skipper-ingress
component: canary
annotations:
kubernetes-log-watcher/scalyr-parser: |
[{"container": "controller", "parser": "keyValue"}]
logging/destination: "{{ .Cluster.ConfigItems.log_destination_both }}"
Comment on lines +21 to +24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MustafaSaber I think the indent needs to align with labels and not metadata. CLM fails to apply the changes: https://app.eu.scalyr.com/y/YiQ9PHLSFdM

strict decoding error: unknown field \"spec.jobTemplate.spec.template.annotations

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏻‍♂️🤦🏻‍♂️

spec:
serviceAccountName: skipper-canary-controller
# Make sure the job run only once
Expand All @@ -27,6 +31,10 @@ spec:
terminationMessagePolicy: FallbackToLogsOnError
image: container-registry.zalando.net/gwproxy/skipper-canary-controller:main-22
env:
- name: POD_NAME
valueFrom:
fieldRef:
fieldPath: metadata.name
- name: _PLATFORM_OBSERVABILITY_ACCESS_TOKEN
valueFrom:
secretKeyRef:
Expand Down