chore(api-usage-monitoring filter): remove deprecated parameter (#949) #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-tschumak
force-pushed
the
949-clean-up-deprecated-default-client-tracking-pattern
branch
from
f376407 to
0915699
Compare
|
👍 |
tkrop
approved these changes
Apr 11, 2019
maxim-tschumak
force-pushed
the
949-clean-up-deprecated-default-client-tracking-pattern
branch
from
0915699 to
74556f9
Compare
szuecs
reviewed
Apr 11, 2019
maxim-tschumak
force-pushed
the
949-clean-up-deprecated-default-client-tracking-pattern
branch
3 times, most recently
from
f8dd553 to
0d784b5
Compare
szuecs
reviewed
Apr 12, 2019
maxim-tschumak
force-pushed
the
949-clean-up-deprecated-default-client-tracking-pattern
branch
from
ae96c03 to
2e3d2a7
Compare
szuecs
reviewed
Apr 16, 2019
|
@maxim-tschumak only a minor nit. |
maxim-tschumak
force-pushed
the
949-clean-up-deprecated-default-client-tracking-pattern
branch
from
0d92f6f to
c35844b
Compare
|
👍 |
1 similar comment
|
👍 |
|
👍 |
1 similar comment
|
👍 |
aryszka
deleted the
949-clean-up-deprecated-default-client-tracking-pattern
branch
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jun 6, 2024
* `-lb-healthcheck-interval` (zalando/skipper#2906) * `-api-usage-monitoring-default-client-tracking-pattern` (zalando/skipper#950 and zalando/skipper#1029) Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #949 - cleaning up an unused deprecated parameter.
Signed-off-by: Maxim Tschumak maxim.tschumak@gmail.com