Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deadcode loadbalancer healthchecker #2906

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

szuecs
Copy link
Member

@szuecs szuecs commented Feb 6, 2024

remove deadcode that is not in use for a while, mark all public configuration as deprecated to delete it later

@szuecs szuecs added refactor minor no risk changes, for example new filters labels Feb 6, 2024
@AlexanderYastrebov
Copy link
Member

Makes sense to also cleanup commented-out usages

skipper/proxy/proxy.go

Lines 919 to 926 in 3082a04

ctx.proxySpan.LogKV("event", "error", "message", ensureUTF8(err.Error()))
if perr, ok := err.(*proxyError); ok {
//p.lb.AddHealthcheck(ctx.route.Backend)
perr.err = fmt.Errorf("failed to do backend roundtrip to %s: %w", req.URL.Host, perr.err)
return nil, perr
} else if nerr, ok := err.(net.Error); ok {
//p.lb.AddHealthcheck(ctx.route.Backend)

…guration as deprecated to delete it later

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
@szuecs
Copy link
Member Author

szuecs commented Feb 6, 2024

@AlexanderYastrebov thanks for the comments, done

@AlexanderYastrebov
Copy link
Member

👍

1 similar comment
@szuecs
Copy link
Member Author

szuecs commented Feb 7, 2024

👍

@szuecs szuecs merged commit f487eb6 into master Feb 7, 2024
14 checks passed
@szuecs szuecs deleted the remove/deadcode branch February 7, 2024 10:29
AlexanderYastrebov added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Jun 6, 2024
* `-lb-healthcheck-interval` (zalando/skipper#2906)
* `-api-usage-monitoring-default-client-tracking-pattern` (zalando/skipper#950 and zalando/skipper#1029)

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit that referenced this pull request Jun 7, 2024
Follow up on #2906

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit that referenced this pull request Jun 7, 2024
Follow up on #2906

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
JanardhanSharma pushed a commit to JanardhanSharma/skipper that referenced this pull request Jul 19, 2024
Follow up on zalando#2906

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor no risk changes, for example new filters refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants