dataclients/kubernetes: remove endpoint addresses cache #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
minor
AlexanderYastrebov
force-pushed
the
dataclients/kubernetes/fix-mutable-addresses
branch
from
a65ced9 to
738dd03
Compare
Returning cached endpoint addreses from exported GetEndpointAddresses makes it possible for caller to modify cached values. Since the logic of obtaining endpoint addresses is lightweight this change simply drops caching altogether. Follow up on #2917 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
dataclients/kubernetes/fix-mutable-addresses
branch
from
738dd03 to
37ac058
Compare
|
|
It benchmarks |
4 tasks
|
Because we cache endpoints/endpointslices, the addresses cache does not really matter. |
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
deleted the
dataclients/kubernetes/fix-mutable-addresses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning cached endpoint addreses from exported GetEndpointAddresses makes it possible for caller to modify cached values.
Since the logic of obtaining endpoint addresses is lightweight this change simply drops caching altogether.
Follow up on #2917
See https://github.com/zalando/skipper/pull/2917/files#r1486405631