Use kubernetes cluster client to discover redis shards #2915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
the
major
AlexanderYastrebov
force-pushed
the
standalone-redis-updater-2
branch
8 times, most recently
from
f56d901 to
6880af8
Compare
Refactor newClusterClient to allow usage of cluster client without dataclient. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Add LoadEndpointAddresses to cluster client. It is similar to caching dataclient GetEndpointAddresses. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Fixes #2476 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
standalone-redis-updater-2
branch
from
6880af8 to
89f45c2
Compare
| @@ -52,7 +52,7 @@ const ( | |||
| const RouteGroupsNotInstalledMessage = `RouteGroups CRD is not installed in the cluster. | |||
| See: https://opensource.zalando.com/skipper/kubernetes/routegroups/#installation` | |||
|
|
|||
| type clusterClient struct { | |||
| type ClusterClient struct { | |||
|
Decided to proceed with #2934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow redis shards discovery using kubernetes cluster client without kubernetes dataclient.
Fixes #2476