skipper: discover redis shards without fetching full cluster state #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
the
major
AlexanderYastrebov
force-pushed
the
standalone-redis-updater-3
branch
from
106e764 to
114eac9
Compare
AlexanderYastrebov
changed the title
This was referenced Feb 13, 2024
AlexanderYastrebov
force-pushed
the
standalone-redis-updater-3
branch
5 times, most recently
from
7f9f986 to
43f7221
Compare
AlexanderYastrebov
force-pushed
the
standalone-redis-updater-3
branch
4 times, most recently
from
5d8e4f9 to
a3da67c
Compare
szuecs
reviewed
Feb 15, 2024
szuecs
reviewed
Feb 15, 2024
szuecs
reviewed
Feb 15, 2024
szuecs
reviewed
Feb 15, 2024
AlexanderYastrebov
force-pushed
the
standalone-redis-updater-3
branch
5 times, most recently
from
be8804c to
9d9056f
Compare
Skipper supports Redis based Cluster Ratelimits and dynamic discovery of Redis instances using Kubernetes Service, see https://github.com/zalando/skipper/blob/master/docs/tutorials/ratelimit.md#redis-based-cluster-ratelimits Dynamic discovery relies on Kubernetes Dataclient that also fetches Ingresses and RouteGroups and creates routes from them. This change enables dynamic discovery of Redis instances using Kubernetes without fetching Ingresses and RouteGroups. When `-kubernetes` flag is not set but `-enable-swarm`, `-kubernetes-redis-service-namespace`, `-kubernetes-redis-service-name` and `-kubernetes-redis-service-port` are provided then Skipper creates Kubernetes dataclient to discover Redis instances but does not use this dataclient for routing. The change adds LoadEndpointAddresses to Kubernetes dataclient that is similar to caching GetEndpointAddresses but does not rely on previous call to Load or LoadAll to allow discovery of Redis shards without fetching full cluster state. Fixes #2476 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
standalone-redis-updater-3
branch
from
9d9056f to
540da27
Compare
szuecs
reviewed
Feb 15, 2024
|
|
||
| When working with Redis swarm, use Kubernetes service selector. Configure it with `-kubernetes-redis-service-namespace` and `-kubernetes-redis-service-name` flags. | ||
| #### HTTP Endpoint |
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
added a commit
that referenced
this pull request
Feb 23, 2024
Routesrv supports dynamic discovery of Redis instances using Kubernetes Service, see https://github.com/zalando/skipper/blob/master/docs/tutorials/ratelimit.md#redis-based-cluster-ratelimits Dynamic discovery relies on Kubernetes Dataclient that also fetches Ingresses and RouteGroups and creates routes from them. This change enables dynamic discovery of Redis instances using Kubernetes without fetching Ingresses and RouteGroups. When -kubernetes flag is not set but -kubernetes-redis-service-namespace, -kubernetes-redis-service-name and -kubernetes-redis-service-port are provided then `routesrv` creates Kubernetes dataclient to discover Redis instances but does not use this dataclient to load routes. See previous #2934 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipper supports Redis based Cluster Ratelimits and
dynamic discovery of Redis instances using Kubernetes Service,
see https://github.com/zalando/skipper/blob/master/docs/tutorials/ratelimit.md#redis-based-cluster-ratelimits
Dynamic discovery relies on Kubernetes Dataclient that also fetches
Ingresses and RouteGroups and creates routes from them.
This change enables dynamic discovery of Redis instances using
Kubernetes without fetching Ingresses and RouteGroups.
When
-kubernetesflag is not set but-enable-swarm,-kubernetes-redis-service-namespace,-kubernetes-redis-service-nameand-kubernetes-redis-service-portare provided then Skipper createsKubernetes dataclient to discover Redis instances
but does not use this dataclient for routing.
The change adds LoadEndpointAddresses to Kubernetes dataclient that is
similar to caching GetEndpointAddresses but does not rely on
previous call to Load or LoadAll to allow discovery of
Redis shards without fetching full cluster state.
Fixes #2476