-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncomment golangci-lint
pre-commit hook
#115
Comments
Closed
/test all |
matt-strong
added a commit
that referenced
this issue
Dec 14, 2021
* re-enable linting * check * error handling * remove unused function, simplify != false * fix formatting issues * use err * ignore error for now * update * regex perf issue * fatalf fix * copy similar errors * next time save before committing 🤦 Co-authored-by: Minimind <882485+jeff-mccoy@users.noreply.github.com>
jeff-mccoy
added a commit
that referenced
this issue
Feb 8, 2022
* re-enable linting * check * error handling * remove unused function, simplify != false * fix formatting issues * use err * ignore error for now * update * regex perf issue * fatalf fix * copy similar errors * next time save before committing 🤦 Co-authored-by: Minimind <882485+jeff-mccoy@users.noreply.github.com> Signed-off-by: Jeff McCoy <code@jeffm.us>
Noxsios
pushed a commit
that referenced
this issue
Mar 8, 2023
* re-enable linting * check * error handling * remove unused function, simplify != false * fix formatting issues * use err * ignore error for now * update * regex perf issue * fatalf fix * copy similar errors * next time save before committing 🤦 Co-authored-by: Minimind <882485+jeff-mccoy@users.noreply.github.com> Signed-off-by: Jeff McCoy <code@jeffm.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uncomment the hook after fixing the golang linting errors
golangci-lint
results:Originally posted by @RothAndrew in #112 (comment)
The text was updated successfully, but these errors were encountered: