Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment golangci-lint pre-commit hook #115

Closed
RothAndrew opened this issue Oct 19, 2021 · 1 comment · Fixed by #175
Closed

Uncomment golangci-lint pre-commit hook #115

RothAndrew opened this issue Oct 19, 2021 · 1 comment · Fixed by #175
Assignees

Comments

@RothAndrew
Copy link
Contributor

RothAndrew commented Oct 19, 2021

Uncomment the hook after fixing the golang linting errors

golangci-lint results:

image

Originally posted by @RothAndrew in #112 (comment)

@RothAndrew RothAndrew mentioned this issue Oct 25, 2021
@matt-strong matt-strong self-assigned this Oct 28, 2021
@matt-strong
Copy link
Contributor

/test all

matt-strong added a commit that referenced this issue Dec 14, 2021
* re-enable linting

* check

* error handling

* remove unused function, simplify != false

* fix formatting issues

* use err

* ignore error for now

* update

* regex perf issue

* fatalf fix

* copy similar errors

* next time save before committing 🤦

Co-authored-by: Minimind <882485+jeff-mccoy@users.noreply.github.com>
jeff-mccoy added a commit that referenced this issue Feb 8, 2022
* re-enable linting

* check

* error handling

* remove unused function, simplify != false

* fix formatting issues

* use err

* ignore error for now

* update

* regex perf issue

* fatalf fix

* copy similar errors

* next time save before committing 🤦

Co-authored-by: Minimind <882485+jeff-mccoy@users.noreply.github.com>
Signed-off-by: Jeff McCoy <code@jeffm.us>
Noxsios pushed a commit that referenced this issue Mar 8, 2023
* re-enable linting

* check

* error handling

* remove unused function, simplify != false

* fix formatting issues

* use err

* ignore error for now

* update

* regex perf issue

* fatalf fix

* copy similar errors

* next time save before committing 🤦

Co-authored-by: Minimind <882485+jeff-mccoy@users.noreply.github.com>
Signed-off-by: Jeff McCoy <code@jeffm.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants