Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#115 Feature/enable linting #175

Merged
merged 17 commits into from
Dec 14, 2021
Merged

#115 Feature/enable linting #175

merged 17 commits into from
Dec 14, 2021

Conversation

matt-strong
Copy link
Contributor

@matt-strong matt-strong commented Nov 16, 2021

Still need to fix regexp lint issue

Fixes #115

@matt-strong
Copy link
Contributor Author

/test all

@matt-strong matt-strong marked this pull request as ready for review December 13, 2021 21:41
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after addressing the comments, thanks

cli/cmd/root.go Show resolved Hide resolved
cli/internal/packager/inspect.go Outdated Show resolved Hide resolved
@matt-strong
Copy link
Contributor Author

/test all

cli/cmd/root.go Outdated Show resolved Hide resolved
@matt-strong
Copy link
Contributor Author

/test all

@jeff-mccoy
Copy link
Contributor

/test all

@matt-strong matt-strong merged commit 92ff8c0 into master Dec 14, 2021
@matt-strong matt-strong deleted the feature/enable_linting branch December 14, 2021 17:35
jeff-mccoy added a commit that referenced this pull request Feb 8, 2022
* re-enable linting

* check

* error handling

* remove unused function, simplify != false

* fix formatting issues

* use err

* ignore error for now

* update

* regex perf issue

* fatalf fix

* copy similar errors

* next time save before committing 🤦

Co-authored-by: Minimind <882485+jeff-mccoy@users.noreply.github.com>
Signed-off-by: Jeff McCoy <code@jeffm.us>
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
* re-enable linting

* check

* error handling

* remove unused function, simplify != false

* fix formatting issues

* use err

* ignore error for now

* update

* regex perf issue

* fatalf fix

* copy similar errors

* next time save before committing 🤦

Co-authored-by: Minimind <882485+jeff-mccoy@users.noreply.github.com>
Signed-off-by: Jeff McCoy <code@jeffm.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncomment golangci-lint pre-commit hook
3 participants