You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- name: dcgm-exporterrequired: truecharts:
- name: dcgm-exporterversion: 3.1.7-3.1.4 # <- this tag doesn't match the chart versionurl: https://github.com/NVIDIA/dcgm-exporter.gitgitPath: deploymentnamespace: "leapfrogai"images:
- "nvcr.io/nvidia/k8s/dcgm-exporter:3.1.7-3.1.4-ubuntu20.04"
This particular application has a mismatch between the git tag and the chart version. This causes an error in either one of two ways since those two are assumed to match:
Build error: If using the version matching the chart version, the package doesn't build since Zarf can't find the Git Tag
Deploy Error: If using the git tag, zarf can't deploy the chart since it can't find a chart with the provided version
Expected result
Be able to deploy an arbitrary chart version from a git repository
Actual Result
Visual Proof (screenshots, videos, text, etc)
Severity/Priority
Additional Context
Add any other context or screenshots about the technical debt here.
Ideas/for implementation:
Add new property to the charts that allows for setting gitVersion separately from version, but have the default gitVersion match the version field
Add more robust regex on the url to allow for passing branch/tag versions in the URL. Some ambiguity here on backwards compatibility. If nothing is set, does it default to the default branch, or the version?
Don't have zarf check to ensure the version matches when deploying a chart from git.
The text was updated successfully, but these errors were encountered:
## Description
What we could do (to keep backwards compat in tact and address
#1766) is see if there is
an @ ref on the git URL and if there is, leave it on there, and if not
append the @tag as we do today. Dedup some code in
src/pkg/packager/prepare.go, and src/pkg/packager/create.go.
## Related Issue
Fixes#1766
<!-- or -->
Relates to
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)
## Checklist before merging
- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
---------
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: razzle <harry@razzle.cloud>
Co-authored-by: razzle <harry@razzle.cloud>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Jon <jonsmith04@hotmail.com>
Steps to reproduce
Create a zarf.yaml with this component:
This particular application has a mismatch between the git tag and the chart version. This causes an error in either one of two ways since those two are assumed to match:
Expected result
Be able to deploy an arbitrary chart version from a git repository
Actual Result
Visual Proof (screenshots, videos, text, etc)
Severity/Priority
Additional Context
Add any other context or screenshots about the technical debt here.
Ideas/for implementation:
charts
that allows for settinggitVersion
separately fromversion
, but have the defaultgitVersion
match theversion
fieldurl
to allow for passing branch/tag versions in the URL. Some ambiguity here on backwards compatibility. If nothing is set, does it default to the default branch, or theversion
?The text was updated successfully, but these errors were encountered: