New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1766 - Git Tag and Chart Version assumed to match #1892

Merged

Racer159 merged 18 commits into main from 1766

Jul 11, 2023

Contributor

cmwylie19 commented Jul 7, 2023

Description

What we could do (to keep backwards compat in tact and address #1766) is see if there is an @ ref on the git URL and if there is, leave it on there, and if not append the @tag as we do today. Dedup some code in src/pkg/packager/prepare.go, and src/pkg/packager/create.go.

Related Issue

Fixes #1766

Relates to

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Other (security config, docs update, etc)

Checklist before merging

Test, docs, adr added or updated as needed
Contributor Guide Steps followed

cmwylie19 and others added 3 commits

July 6, 2023 19:55


          [TASK] TransformGitURL helm helper

7f8f109

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>


          [TASK] refactor for urls/reduce duplication

46d1b6d

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>


          zarf bundle ADR (#1820)

9048dd0

## Description

Creates a `pending` ADR for initial work on `zarf bundle`.

## Related Issue

Relates to #1711

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Signed-off-by: razzle <harry@razzle.cloud>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Casey Wylie <cmwylie19@defenseunicorns.com>

netlify bot commented Jul 7, 2023 •

edited

Loading

✅ Deploy Preview for zarf-docs canceled.

Name	Link
🔨 Latest commit	`ae36435`
🔍 Latest deploy log	https://app.netlify.com/sites/zarf-docs/deploys/64ad996fbd9fa50008eb2e32

cmwylie19 mentioned this pull request

[TASK] TransformGitURL helm helper #1886

Closed

5 tasks


          Merge branch 'main' into 1766

f6d3444

cmwylie19 added the needs-tests label

cmwylie19 added 2 commits

July 9, 2023 15:38


          [TASK] buildChartDependencies

ea6ca34

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>


          [TASK] dependency build

42019e5

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>

cmwylie19 changed the title ~~1766~~ 1766 - Git Tag and Chart Version assumed to match

Racer159 mentioned this pull request

Adds support to mutate repoURL in Application CRD and Repositories for ArgoCD #1875

Merged

5 tasks

Noxsios and others added 3 commits

July 10, 2023 17:02


          Hotfix: only verify authentication to registry if creds exist (#1893)

718f553

## Description

Fixes what I broke.

This does re-architect some portions of OrasRemote and locks it down
more. Everything in `*remote.Registry` is no longer exposed to outside
usage and users of this remote client are restricted to the public
receiver methods written in `pkg/oci`.

The context is now private as it really should not be edited outside of
private receivers within OrasRemote.

During the writing of this PR I found out that ORAs already handles
scopes at the request level and there is zero need to handle scopes
yourself. I have not checked if I never had to do this, or if ORAs
updated.

## Related Issue

Fixes #1881 
Fixes #1795 
Fixes #1821 

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Signed-off-by: razzle <harry@razzle.cloud>


          Add ExitOnInterrupt utils function; catch interrupts when using wait (#…

7d173a2

…1891)

Add ExitOnInterrupt utils function; catch interrupts when using wait

## Description

Add ability to catch interrupts when using wait command.

## Related Issue

Fixes #1864

## Type of change

- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>


          [TASK] Update bb test for new development

036760d

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>

Contributor Author

cmwylie19 commented Jul 10, 2023

I am removing the needs-tests label because I am going to address the tests in the metrics pr as this current PR is a prereq along with the named port pr and the waitFor pr which has been merged.


          Merge branch 'main' into 1766

7c83039

cmwylie19 removed the needs-tests label

cmwylie19 marked this pull request as ready for review

July 10, 2023 21:09

cmwylie19 requested review from jeff-mccoy, YrrepNoj, Racer159 and Noxsios as code owners

July 10, 2023 21:09

cmwylie19 mentioned this pull request

[FEATURE] add metrics to zarf-agent #1853

Closed

5 tasks

Racer159 requested changes

View reviewed changes

src/internal/packager/helm/repo.go Show resolved Hide resolved

src/internal/packager/helm/repo.go Outdated Show resolved Hide resolved

cmwylie19 and others added 5 commits

July 10, 2023 17:25


          Update src/internal/packager/helm/repo.go

55723c3

Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>


          Merge branch 'main' into 1766

1c284e3


          [TASK] lint PackageChart

8e0e38b

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>


          Merge branch 'main' into 1766

b696b0d


          Merge branch 'main' into 1766

0c48601

Noxsios reviewed

View reviewed changes

src/internal/packager/helm/repo.go Outdated Show resolved Hide resolved

Noxsios reviewed

View reviewed changes

src/pkg/transform/git.go Show resolved Hide resolved


          [TASK] remove package name from func and add test cases

0d0cac8

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>

Racer159 requested changes

View reviewed changes

src/pkg/transform/git_test.go Show resolved Hide resolved

src/pkg/transform/git.go Show resolved Hide resolved


          [TASK] rename gitTransform functions appropriately according to go st…

b6bcc4f

…andards

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>

Noxsios previously approved these changes

View reviewed changes


          [TASK] add two more test cases

ae36435

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>

cmwylie19 dismissed Noxsios’s stale review via

ae36435

July 11, 2023 18:03

Racer159 approved these changes

View reviewed changes

Contributor

Racer159 left a comment

lgtm

Racer159 merged commit 12bbda8 into main

Racer159 deleted the 1766 branch

July 11, 2023 21:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet