Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use action defaults MaxTotalSeconds during Big Bang deploy #1782

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented Jun 2, 2023

Description

This PR makes it so that the Big Bang extension respects and uses the onDeploy.defaults.maxTotalSeconds field during its onSuccess actions to wait for HelmReleases to be ready.

The default time is still ten minutes (600s), but if a default is specified and is greater than 600, it will use that instead.

components:
  - name: bigbang
    extensions:
      bigbang:
        version: 2.0.0
        valuesFiles:
          - config/disable-all.yaml
    actions:
      onDeploy:
        defaults:
          maxTotalSeconds: 1200 # 20 minutes in seconds

Related Issue

Fixes #1780

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: razzle <harry@razzle.cloud>
@Noxsios Noxsios linked an issue Jun 2, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jun 2, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 88332d1
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/647abbf36cd40c000821f84e

@Noxsios Noxsios marked this pull request as ready for review June 3, 2023 04:05
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit c38f33d into main Jun 3, 2023
@Racer159 Racer159 deleted the 1780-big-bang-extension-allow-for-customizing-wait-time-on-helmreleases branch June 3, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Big Bang Extension: Allow for customizing wait time on helmreleases
2 participants