Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use action defaults MaxTotalSeconds during Big Bang deploy #1782

Merged
merged 3 commits into from
Jun 3, 2023
Merged

Use action defaults MaxTotalSeconds during Big Bang deploy #1782

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df71bc6
use action default during deploy bb
Noxsios Jun 2, 2023
ac8ae4b
Merge branch 'main' into 1780-big-bang-extension-allow-for-customizin…
Noxsios Jun 3, 2023
88332d1
only override if the given timeout is greater than 10 minutes
Noxsios Jun 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/extensions/bigbang/bigbang.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,14 +139,20 @@ func Run(YOLO bool, tmpPaths types.ComponentPaths, c types.ZarfComponent) (types
return c, fmt.Errorf("unable to sort Big Bang HelmReleases: %w", err)
}

tenMinsInSecs := 10 * 60
// ten minutes in seconds
maxTotalSeconds := 10 * 60

defaultMaxTotalSeconds := c.Actions.OnDeploy.Defaults.MaxTotalSeconds
if defaultMaxTotalSeconds > maxTotalSeconds {
maxTotalSeconds = defaultMaxTotalSeconds
}

// Add wait actions for each of the helm releases in generally the order they should be deployed.
for _, hrNamespacedName := range namespacedHelmReleaseNames {
hr := hrDependencies[hrNamespacedName]
action := types.ZarfComponentAction{
Description: fmt.Sprintf("Big Bang Helm Release `%s` to be ready", hr.Metadata.Name),
MaxTotalSeconds: &tenMinsInSecs,
MaxTotalSeconds: &maxTotalSeconds,
Wait: &types.ZarfComponentActionWait{
Cluster: &types.ZarfComponentActionWaitCluster{
Kind: "HelmRelease",
Expand Down