Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: layout #3022

Merged
merged 1 commit into from
Oct 1, 2024
Merged

refactor: layout #3022

merged 1 commit into from
Oct 1, 2024

Conversation

phillebaba
Copy link
Member

Description

The change refactors packager layout.

Related Issue

Relates to #2969

Checklist before merging

@phillebaba phillebaba requested review from a team as code owners September 23, 2024 19:42
@phillebaba phillebaba marked this pull request as draft September 23, 2024 19:42
@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 7f2f1d6
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66fc2186f1e57800087e50df

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.00000% with 121 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/layout/package.go 50.56% 55 Missing and 32 partials ⚠️
src/internal/packager2/mirror.go 0.00% 19 Missing ⚠️
src/internal/packager2/inspect.go 0.00% 12 Missing ⚠️
src/cmd/package.go 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/load.go 62.37% <100.00%> (+6.37%) ⬆️
src/cmd/package.go 0.00% <0.00%> (ø)
src/internal/packager2/inspect.go 0.00% <0.00%> (ø)
src/internal/packager2/mirror.go 0.00% <0.00%> (ø)
src/internal/packager2/layout/package.go 50.56% <50.56%> (ø)

@phillebaba phillebaba force-pushed the refactor/layout branch 21 times, most recently from ee669e6 to 5f819c8 Compare September 30, 2024 19:38
@phillebaba phillebaba marked this pull request as ready for review September 30, 2024 19:39
schristoff
schristoff previously approved these changes Oct 1, 2024
View reviewed changes
@phillebaba
refactor: layout
7f2f1d6 
Signed-off-by: Philip Laine <philip.laine@gmail.com>
@phillebaba phillebaba added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 117433c Oct 1, 2024
28 checks passed
@phillebaba phillebaba deleted the refactor/layout branch October 1, 2024 17:34
ittacco pushed a commit to ittacco/zarf that referenced this pull request Nov 9, 2024
@phillebaba @ittacco
refactor: layout (zarf-dev#3022)
55cded8 
Signed-off-by: Philip Laine <philip.laine@gmail.com>
Signed-off-by: ittacco <lorenzo.tacconi1967@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phillebaba @schristoff