Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor flavor e2e test to not depend on CLI output #3125

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

phillebaba
Copy link
Member

Description

This change removes any use of CLI output for flavor e2e tests. This enables the refactoring of log output without breaking the e2e tests.

Related Issue

Relates to #2576
Relates to #2969

Checklist before merging

@phillebaba phillebaba requested review from a team as code owners October 22, 2024 15:33
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 7081be6
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6717d72449480400087eb979

@phillebaba phillebaba force-pushed the refactor/flavor-test branch from 6315506 to 1c46168 Compare October 22, 2024 15:34
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@phillebaba phillebaba force-pushed the refactor/flavor-test branch from 1c46168 to 79afbbf Compare October 22, 2024 16:47
Signed-off-by: Philip Laine <philip.laine@gmail.com>
@phillebaba phillebaba added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 8f61a5b Oct 22, 2024
26 checks passed
@phillebaba phillebaba deleted the refactor/flavor-test branch October 22, 2024 18:03
Jneville0815 pushed a commit to radiusmethod/zarf that referenced this pull request Dec 12, 2024
Signed-off-by: Philip Laine <philip.laine@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants