Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor templating e2e test to not depend on CLI output #3147

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

phillebaba
Copy link
Member

Description

This change removes any use of CLI output for templating e2e tests. This enables the refactoring of log output without breaking the e2e tests.

Related Issue

Relates to #2576
Relates to #2969

Checklist before merging

Signed-off-by: Philip Laine <philip.laine@gmail.com>
@phillebaba phillebaba requested review from a team as code owners October 25, 2024 12:27
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 67eae64
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/671b8ed0b7794e0008c5d68b

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 22dd49a Oct 25, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the refactor/template-test branch October 25, 2024 15:09
Jneville0815 pushed a commit to radiusmethod/zarf that referenced this pull request Dec 12, 2024
Signed-off-by: Philip Laine <philip.laine@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants