Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor migrate deprecated #3270

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Refactor migrate deprecated #3270

merged 1 commit into from
Dec 2, 2024

Conversation

phillebaba
Copy link
Member

Description

This change refactors the deprecation migration and adds unit tests.

Related Issue

Relates to #2969

Checklist before merging

@phillebaba phillebaba requested review from a team as code owners November 25, 2024 17:46
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 98a302b
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6744b81f55ac8a000800845a

@phillebaba
Refactor refactor migrate deprecated
98a302b 
Signed-off-by: Philip Laine <philip.laine@gmail.com>
@phillebaba phillebaba changed the title Refactor refactor migrate deprecated Refactor migrate deprecated Nov 25, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.02985% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/layout/deprecated.go 93.98% 6 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/layout/create.go 56.77% <ø> (-1.10%) ⬇️
src/internal/packager2/layout/layout.go 62.50% <100.00%> (-10.23%) ⬇️
src/internal/packager2/layout/deprecated.go 93.98% <93.98%> (ø)

AustinAbro321
AustinAbro321 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job simplifying and adding tests

@phillebaba phillebaba added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit f36414b Dec 2, 2024
26 checks passed
@phillebaba phillebaba deleted the refactor/deprecated branch December 2, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinAbro321 AustinAbro321 AustinAbro321 approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phillebaba @AustinAbro321