chore: remove deprecated get git password command #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321
changed the title
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AustinAbro321
commented
Dec 5, 2024
| @@ -237,7 +237,7 @@ var devSha256SumCmd = &cobra.Command{ | |||
| } | |||
|
|
|||
| var devFindImagesCmd = &cobra.Command{ | |||
| Use: "find-images [ PACKAGE ]", | |||
| Use: "find-images [ DIRECTORY ]", | |||
There was a problem hiding this comment.
sneaking this in a bit, but noticed this while writing the ZEPs. This runs on a directory not a package. Switching this to use the same verbiage used in zarf package create.
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321
changed the title
schristoff
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the deprecated get git password command which has been deprecated for over a year. It was replaced by
zarf tools get-creds git. This command was already broken because when the get-creds command was updated to use theRunEfunction,get-git-passwordwas not updated so it panic'dChecklist before merging