Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated get git password command #3293

Merged
merged 2 commits into from
Dec 5, 2024
Merged

chore: remove deprecated get git password command #3293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06be028
remove deprecated get git password
AustinAbro321 Dec 5, 2024
e687a38
make docs and schema
AustinAbro321 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/src/content/docs/commands/zarf_dev_find-images.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Evaluates components in a Zarf file to identify images specified in their helm c
Components that have repos that host helm charts can be processed by providing the --repo-chart-path.

```
zarf dev find-images [ PACKAGE ] [flags]
zarf dev find-images [ DIRECTORY ] [flags]
```

### Options
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/dev.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ var devSha256SumCmd = &cobra.Command{
}

var devFindImagesCmd = &cobra.Command{
Use: "find-images [ PACKAGE ]",
Use: "find-images [ DIRECTORY ]",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sneaking this in a bit, but noticed this while writing the ZEPs. This runs on a directory not a package. Switching this to use the same verbiage used in zarf package create.

Aliases: []string{"f"},
Args: cobra.MaximumNArgs(1),
Short: lang.CmdDevFindImagesShort,
Expand Down
12 changes: 0 additions & 12 deletions src/cmd/tools/zarf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,6 @@ const (
agentKey = "agent"
)

var deprecatedGetGitCredsCmd = &cobra.Command{
Use: "get-git-password",
Hidden: true,
Short: lang.CmdToolsGetGitPasswdShort,
Long: lang.CmdToolsGetGitPasswdLong,
Run: func(_ *cobra.Command, _ []string) {
message.Warn(lang.CmdToolsGetGitPasswdDeprecation)
getCredsCmd.Run(getCredsCmd, []string{"git"})
},
}

var getCredsCmd = &cobra.Command{
Use: "get-creds",
Short: lang.CmdToolsGetCredsShort,
Expand Down Expand Up @@ -416,7 +405,6 @@ var generateKeyCmd = &cobra.Command{
func init() {
v := common.InitViper()

toolsCmd.AddCommand(deprecatedGetGitCredsCmd)
toolsCmd.AddCommand(getCredsCmd)

toolsCmd.AddCommand(updateCredsCmd)
Expand Down
Loading