Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mypy configuration to not ignore all missing imports #144

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

codingpaula
Copy link
Contributor

This PR edits the mypy config in the pyproject.toml to not ignore all missing imports. Instead it specifies the modules that don't have type annotations and need to be ignored.
It also fixes some minor things, mypy was complaining about:

  • the @analysis.track in the driver.py wasn't properly recognized because the file and the instance of Track were called the same
  • the usb_device.py uses the VideoWriter.fourcc function instead of VideoWriter__fourcc (as explained here: VideoWriter_fourcc doesn't exist in type stubs opencv/opencv#24818)
  • the hardware_proxy.py was removed, since it's not used and wouldn't work correctly in it's current form

@codingpaula codingpaula added the enhancement New feature or request label Jul 11, 2024
@codingpaula codingpaula added this to the 0.11.0 milestone Jul 11, 2024
@codingpaula codingpaula self-assigned this Jul 11, 2024
@falkoschindler falkoschindler merged commit 60d60d2 into main Jul 11, 2024
5 checks passed
@falkoschindler falkoschindler deleted the mypy-imports branch July 11, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants