Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linux] Cannot copy "About Zed" information #21305

Closed
1 task done
SomeoneToIgnore opened this issue Nov 28, 2024 · 0 comments · Fixed by #21405
Closed
1 task done

[Linux] Cannot copy "About Zed" information #21305

SomeoneToIgnore opened this issue Nov 28, 2024 · 0 comments · Fixed by #21405
Labels
bug [core label] linux mouse interaction Feedback for mouse interaction states, actions, etc

Comments

@SomeoneToIgnore
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Technically, any Zed Linux popovers seem to disallow copying, so I might have missed the issue.

But this particular popover is the most crucial, as for e.g. Nightly it contains a long SHA version in it.

Open the menu, under Help section select About Zed, a new popover opens:

image

Expected: can select and copy any text in it, same as in masOS modal
Actual: nothing but the button is interactive

I had to open a macOS version and copy over that SHA into the issue

Environment

Zed Nightly 0.165.0 cacec06

Linux alpc 6.11.8-300.fc41.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Nov 14 20:37:39 UTC 2024 x86_64 GNU/Linux

LSB Version: n/a
Distributor ID: Fedora
Description: Fedora Linux 41 (Workstation Edition)
Release: 41
Codename: n/a

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log
@SomeoneToIgnore SomeoneToIgnore added bug [core label] triage Maintainer needs to classify the issue admin read Pending admin review labels Nov 28, 2024
@Moshyfawn Moshyfawn added mouse interaction Feedback for mouse interaction states, actions, etc linux and removed triage Maintainer needs to classify the issue labels Nov 28, 2024
@github-actions github-actions bot mentioned this issue Nov 29, 2024
Open
@0xtimsb 0xtimsb mentioned this issue Dec 2, 2024
Merged
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Dec 3, 2024
@MonstraG MonstraG mentioned this issue Dec 4, 2024
Closed
1 task
mikayla-maki pushed a commit that referenced this issue Dec 6, 2024
@0xtimsb
linux: Make prompt detail selectable (#21405)
bffdc55 
Closes #21305

As Linux doesn’t have native prompts, Zed uses a custom GPU-based
prompt, like the "About Zed" prompt. Currently, the detail in the prompt
isn’t selectable.

This PR fixes that by using the editor's multi-line selectable
functionality to make the detail selectable (and thus copyable). It
achieves this by disabling editing and setting the cursor to
transparent. The editor also does all the heavy lifting, like
double-clicking to select a word or triple-clicking to select a line,
like what user expects from selectable.

Before/After:

<img
src="https://github.com/user-attachments/assets/2012a6cc-a1ed-4efe-8bfb-440a9259f07a"
alt="before" width="360px" />

<img
src="https://github.com/user-attachments/assets/31922ef5-cb2d-4e90-a1a1-00843e767432"
alt="after" width="360px" />

When detail is `None` or empty string:

<img
src="https://github.com/user-attachments/assets/2be5c921-bda1-4db3-85cd-b4b0e2df86d2"
alt="none" width="360px" />

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [core label] linux mouse interaction Feedback for mouse interaction states, actions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

linux: Make prompt detail selectable 0xtimsb/zed
3 participants
@SomeoneToIgnore @Moshyfawn @JosephTLyons