-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid nested structs in the types used to pass data from vertex to fragment shader functions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to compile successfully on macos versions <= 10.15 (catalina)
Pretty weird error but excellent work figuring this out! ⚡ |
leizaf
pushed a commit
to leizaf/zed
that referenced
this pull request
Jan 26, 2024
Add haskell grammar
1 task
1 task
gabydd
pushed a commit
to gabydd/zed
that referenced
this pull request
Feb 26, 2024
linux/x11: Move from dedicated thread to fd source for event loop
1 task
1 task
1 task
d1y
pushed a commit
to d1y/zed1
that referenced
this pull request
Jun 25, 2024
Set up ground work for debugger config files
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
Closed
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
This was referenced Nov 28, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be required in order for the shaders to compile successfully on macOS versions <= 10.15 (Catalina). In these versions, when nested structs are used, we get errors like this:
for vertex function return types:
for fragment function inputs: