Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-JIRA] Bump lerna from 5.1.8 to 8.1.5 (palindromic upgrade) #235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jun 25, 2024

  1. Bump lerna from 5.1.8 to 8.1.5 (palindromic upgrade)

    - Let's use the latest and greatest lerna
    - Note that `lerna bootstrap` is replaced with `yarn install` post lerna v7 [1],
      and since this was leveraged in a postinstall script we can (and should) just
      remove, as otherwise now `yarn install` will recursively install, forever.
    - Similarly, `lerna link` is no longer necessary post lerna v7, as package
      linking is done automagically as part of the `yarn install` process [2], so we
      should just delete any occurrences of this, such as in the link_dev script.
    - Finally, as of lerna 7.0.0+ workspaces are enabled by default so the
      useWorkspaces key in lerna.json should be removed [3], this is a breaking
      change for lerna 7+ that also needs to be made to the project config. Simple
      enough, all that is required to just to delete the relevant key from
      lerna.json.
    
    [1] https://lerna.js.org/docs/legacy-package-management#:~:text=Replace%20lerna%20bootstrap%20with%20npm%20install%20(or%20yarn/pnpm).%20If%20you%20are%20already%20performing%20your%20package%20manager%27s%20install%20command%20somewhere%20in%20your%20workflow%20before%20where%20you%20had%20previously%20called%20lerna%20bootstrap%2C%20then%20you%20can%20just%20delete%20it%20instead
    [2] https://lerna.js.org/docs/legacy-package-management#:~:text=lerna%20link%20can%20just%20be%20removed%2C%20as%20the%20linking%20step%20is%20now%20handled%20by%20your%20package%20manager%20during%20npm%20install.
    [3] https://github.com/lerna/lerna/blob/main/CHANGELOG.md#:~:text=Workspaces%20are%20used%20by%20default%20and%20useWorkspaces%20has%20been%20removed
    token-cjg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    f03f9d8 View commit details
    Browse the repository at this point in the history