This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Ensure component works under PHP 7.2 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Requires updating to zend-inputfilter 2.8 series. - Requires updating to zend-session 2.8 series.
- legacy dependencies - removed composer self-update - removed allow_failures on PHP 7.2 - cs-checks and coverage moved to run on PHP 7.1 with locked deps
V1.5 of that library only supports PHP 7.1 and up, so locked versions of PHP 7 and PHP 5.5 need to be able to get the latest versions that that library supports for their PHP version.
Version 3.3 requires PHP 7.1.
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2017
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates minimum supported versions of zend-inputfilter and zend-session to their 2.8 series, which offer PHP 7.2 support, and updates CI configuration to require PHP 7.2 builds to pass.