This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Add PHP 7.2 support, drop HHVM #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also depends on zendframework/zend-inputfilter#142 |
.travis.yml
Outdated
| @@ -60,17 +59,17 @@ matrix: | |||
| - php: 7.1 | |||
| env: | |||
| - DEPS=latest | |||
| - php: hhvm | |||
| - php: nightly | |||
There was a problem hiding this comment.
nightly now refers to PHP 7.3-dev, we should then add also PHP 7.2 here.
@Slamdunk would you be able to update your PR, please?
There was a problem hiding this comment.
The main point to refer to nightly is to test against 7.2, not the latest.
I'll change nightly to 7.2, removing nightly entirely; it is too early to bother to 7.3
There was a problem hiding this comment.
Done, thank you for suggestion
|
+1 |
|
PHP 7.2 was released today. Can we merge this PR? Ping @webimpress |
|
@thomasvargiu Sorry, I do not have permissions to do that :(
…On 30 Nov 2017, 18:32 +0000, Thomas Mauro Vargiu ***@***.***>, wrote:
PHP 7.2 was released today. Can we merge this PR?
Ping @webimpress
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Ya |
|
@Ocramius any chance to have a release for this fix ? |
Closed
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.travis.ymlZF standards (zend-session/.travis.yml picked)Fatal error: Declaration of Zend\Form\Form::bindValues(array $values = Array) must be compatible with Zend\Form\Fieldset::bindValues(array $values = Array, ?array $validationGroup = NULL) in /tmp/zend-form/src/Form.php1) ZendTest\Form\View\Helper\FormSelectTest::testScalarOptionValues with data set #0 (array('string')) The each() function is deprecated.